Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User does not see feedback in the Reset Password form when the passwords don't match #322

Open
francisli opened this issue Oct 5, 2023 · 1 comment

Comments

@francisli
Copy link
Collaborator

Reproduce:

  1. Open Routed to the Login page
  2. Go to Forgot your password?
  3. Submit a registered email address, i.e. [email protected]
  4. Open the link in the email (in development, open Mailcatcher on http://localhost:1080)
  5. In the Reset Password form, type different passwords in Password/Confirm Password
  6. Observe: no feedback, submit button remains disabled

Possible solutions:

  1. Perform validation on debounced input changes in Confirm Password field, and show an error message when values don't match. This could be annoying as you may see the error message while you're still typing the password (depending on debounce timing)

  2. Leave the Reset Password button enabled, and do the match validation on submit. Note that currently, the back-end is not doing validation, only the front end. Should we do both?

@fwextensions
Copy link
Collaborator

1 might be okay with like a 1s - 2s debounce, so it's not validating as you type, just when you pause (which is probably once you've finished typing, unless you're really slow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants