Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all of the commands in the blueprint are being ran #82

Open
notmessenger opened this issue Sep 17, 2015 · 3 comments
Open

Not all of the commands in the blueprint are being ran #82

notmessenger opened this issue Sep 17, 2015 · 3 comments

Comments

@notmessenger
Copy link
Contributor

The only step in the blueprint (blueprints/ember-cli-blanket/index.js) that gets ran is the this.addBowerPackageToProject call. The other steps were not ran for me in multiple test installs. My version of Ember CLI is 1.13.8.

@sglanzer-deprecated
Copy link
Owner

Hmm, we're definitely behind on the ember-cli version (there is a PR for this), but I've been working with the same hooks for another cli based project in 1.13.8, so they should still be legitimate.

I'll poke into this and see if the promise chain is being broken after the CLI upgrade PR is merged.

@benwalder
Copy link

👍 for a fix needed.

The second step in the blueprint for tests/index.html is failing. tests/index.html has only LF by default. require('os').EOL returns CR on windows. The code is looking to find the "after" line by matching on a test string that ends with CR. Its not found because the line ends with LF. No change is made to the file. A promise is not returned from insertIntoFile(). It fails silently.

It probably should look for both LF and CRLF? I can put together a PR if that seems reasonable.

@jschilli
Copy link
Collaborator

jschilli commented Apr 1, 2016

@sfbwalder PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants