From b3cf85c1d4453b6f0cf299f566107321d9b039ce Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Sat, 7 Dec 2024 13:17:01 +0100 Subject: [PATCH] lib/: Rename local variable Call it 'dup', which reminds that it's a strdup(3)d string. Signed-off-by: Alejandro Colomar --- lib/gshadow.c | 12 ++++++------ lib/sgetgrent.c | 12 ++++++------ lib/sgetpwent.c | 10 +++++----- lib/sgetspent.c | 12 ++++++------ 4 files changed, 23 insertions(+), 23 deletions(-) diff --git a/lib/gshadow.c b/lib/gshadow.c index e08e1d66b0..ee997b09d6 100644 --- a/lib/gshadow.c +++ b/lib/gshadow.c @@ -72,25 +72,25 @@ void endsgent (void) /*@observer@*//*@null@*/struct sgrp * sgetsgent(const char *s) { - static char *sgrbuf = NULL; + static char *dup = NULL; char *fields[FIELDS]; char *cp; int i; - free(sgrbuf); - sgrbuf = strdup(s); - if (sgrbuf == NULL) + free(dup); + dup = strdup(s); + if (dup == NULL) return NULL; - stpsep(sgrbuf, "\n"); + stpsep(dup, "\n"); /* * There should be exactly 4 colon separated fields. Find * all 4 of them and save the starting addresses in fields[]. */ - for (cp = sgrbuf, i = 0; (i < FIELDS) && (NULL != cp); i++) + for (cp = dup, i = 0; (i < FIELDS) && (NULL != cp); i++) fields[i] = strsep(&cp, ":"); /* diff --git a/lib/sgetgrent.c b/lib/sgetgrent.c index f65ba18d4f..52fe891bcd 100644 --- a/lib/sgetgrent.c +++ b/lib/sgetgrent.c @@ -67,20 +67,20 @@ list(char *s) struct group * sgetgrent(const char *s) { - static char *grpbuf = NULL; + static char *dup = NULL; static char *grpfields[NFIELDS]; static struct group grent; int i; char *cp; - free(grpbuf); - grpbuf = strdup(s); - if (grpbuf == NULL) + free(dup); + dup = strdup(s); + if (dup == NULL) return NULL; - stpsep(grpbuf, "\n"); + stpsep(dup, "\n"); - for (cp = grpbuf, i = 0; (i < NFIELDS) && (NULL != cp); i++) + for (cp = dup, i = 0; (i < NFIELDS) && (NULL != cp); i++) grpfields[i] = strsep(&cp, ":"); if (i < (NFIELDS - 1) || *grpfields[2] == '\0' || cp != NULL) { diff --git a/lib/sgetpwent.c b/lib/sgetpwent.c index a1c2002004..ef2db76c5c 100644 --- a/lib/sgetpwent.c +++ b/lib/sgetpwent.c @@ -40,15 +40,15 @@ struct passwd * sgetpwent(const char *s) { - static char *pwdbuf = NULL; + static char *dup = NULL; static struct passwd pwent; int i; char *cp; char *fields[NFIELDS]; - free(pwdbuf); - pwdbuf = strdup(s); - if (pwdbuf == NULL) + free(dup); + dup = strdup(s); + if (dup == NULL) return NULL; /* @@ -56,7 +56,7 @@ sgetpwent(const char *s) * field. The fields are converted into NUL terminated strings. */ - for (cp = pwdbuf, i = 0; (i < NFIELDS) && (NULL != cp); i++) + for (cp = dup, i = 0; (i < NFIELDS) && (NULL != cp); i++) fields[i] = strsep(&cp, ":"); /* something at the end, columns over shot */ diff --git a/lib/sgetspent.c b/lib/sgetspent.c index 82c31ca110..bd06b96e81 100644 --- a/lib/sgetspent.c +++ b/lib/sgetspent.c @@ -38,25 +38,25 @@ struct spwd * sgetspent(const char *s) { - static char *spwbuf = NULL; + static char *dup = NULL; static struct spwd spwd; char *fields[FIELDS]; char *cp; int i; - free(spwbuf); - spwbuf = strdup(s); - if (spwbuf == NULL) + free(dup); + dup = strdup(s); + if (dup == NULL) return NULL; - stpsep(spwbuf, "\n"); + stpsep(dup, "\n"); /* * Tokenize the string into colon separated fields. Allow up to * FIELDS different fields. */ - for (cp = spwbuf, i = 0; cp != NULL && i < FIELDS; i++) + for (cp = dup, i = 0; cp != NULL && i < FIELDS; i++) fields[i] = strsep(&cp, ":"); if (i == (FIELDS - 1))