Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sulogin is not being installed #1082

Open
firasuke opened this issue Sep 23, 2024 · 4 comments
Open

sulogin is not being installed #1082

firasuke opened this issue Sep 23, 2024 · 4 comments

Comments

@firasuke
Copy link

Hey there,

Thank for your time and effort.

I noticed that shadow's sulogin is being built under src/, but it is not being installed when running make install. Having checked src/Makefile it seems that it is under noinst_PROGRAMS.

Is this intended behavior? Does this mean that util-linux's sulogin is the version to use?

Thanks in advance!

@alejandro-colomar
Copy link
Collaborator

Is this intended behavior?

Having an explicit line in the Makefile.am, I'd say yes, it was intended. But I don't know why it was intended. The git-blame(1) says it's a very old line.

Does this mean that util-linux's sulogin is the version to use?

Probably. You could check what distros are doing.

@firasuke
Copy link
Author

Does this mean that util-linux's sulogin is the version to use?

Probably. You could check what distros are doing.

util-linux's version of sulogin is indeed what is being used by almost all distributions. I guess shadow's sulogin could be dropped then?

@alejandro-colomar
Copy link
Collaborator

Does this mean that util-linux's sulogin is the version to use?

Probably. You could check what distros are doing.

util-linux's version of sulogin is indeed what is being used by almost all distributions.

re: almost: Did you find any one that doesn't?

I guess shadow's sulogin could be dropped then?

It depends on your response to the above question. If none at all are using it, maybe it would make sense to remove it, since I wouldn't trust a program that nobody has been using at all for years. If there's any user, I guess we should keep it.

@firasuke
Copy link
Author

firasuke commented Sep 29, 2024

re: almost: Did you find any one that doesn't?

Yes, after a basic search on publicly available code on GitHub, I found some slackware recipes and some Chimera Linux recipes that are explicitly installing shadow's version of sulogin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants