Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manpage updates #1173

Open
zeha opened this issue Jan 8, 2025 · 10 comments
Open

Manpage updates #1173

zeha opened this issue Jan 8, 2025 · 10 comments

Comments

@zeha
Copy link
Contributor

zeha commented Jan 8, 2025

Hi,

Markus Hiereth sent some man page updates to the Debian BTS, and @hallyn interacted there with them in the past. Could upstream please either take or reject these updates?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005253

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1004688

Thanks :)

@zeha
Copy link
Contributor Author

zeha commented Jan 8, 2025

@zeha zeha changed the title Manpage updates from Markus Hiereth Manpage updates Jan 8, 2025
@zeha
Copy link
Contributor Author

zeha commented Jan 8, 2025

@zeha
Copy link
Contributor Author

zeha commented Jan 8, 2025

@alejandro-colomar
Copy link
Collaborator

alejandro-colomar commented Jan 8, 2025

Hi @zeha ,

To be able to review the changes to the manual pages, I'd like to see them in patches with commit messages that justifies the changes. A huge diff without justification isn't easy to review.

@alejandro-colomar
Copy link
Collaborator

Could you ask that user to provide a patch set (not a single patch) where each patch does one thing and is justified?

@zeha
Copy link
Contributor Author

zeha commented Jan 8, 2025

Could you ask that user to provide a patch set (not a single patch) where each patch does one thing and is justified?

I fear this will be unlikely to bear much fruit. Please just take whatever you think is right, and I can close the rest pointing here, if need be.

@alejandro-colomar
Copy link
Collaborator

Hmmmm, okay. How about if you send the diffs as a huge PR with no details at all? We can keep that PR as a draft, and then I'll slowly pick stuff from there.

Is that okay for you?

@zeha
Copy link
Contributor Author

zeha commented Jan 8, 2025

Here's what I got out of the first three bugs:
#1175

Notably from the first bug a lot was already applied in master, and patch failed to apply most of the remaining hunks.

The chage submission doesn't include a patch against the XML, so I didn't include that.

@zeha
Copy link
Contributor Author

zeha commented Jan 8, 2025

i18n updates:

#1176

#1177

#1178

@alejandro-colomar
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants