Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Alternate list preview background #2258

Open
1 task done
MuntKaicho opened this issue Jan 28, 2025 · 11 comments · May be fixed by #2334
Open
1 task done

[Feature Request]: Alternate list preview background #2258

MuntKaicho opened this issue Jan 28, 2025 · 11 comments · May be fixed by #2334

Comments

@MuntKaicho
Copy link

Checklist

  • I have searched for a similar issue in this repository and did not find one.

Description

So the current implementation where the emu scrapes pic1.png from the game files and then applies the blur looks kinda weird in some situations, especially with brighter images.
I think that just taking the image and applying a simple 90% opacity full black overlay atop the image or just taking the image and generating a version of it that only has 10% opacity can yield better results.

Current:
Image

Proposed black overlay:
Image

Proposed 10% opacity:
Image

Reason

The current implementation looks strange, as if there isn't just gaussian blur applied, but also has a low resolution look to it.

Examples

No response

@MuntKaicho
Copy link
Author

Did some more testing and 15% is better for the 2nd method because 10% kinda kills off all detail in very dark images like Bloodborne

@Hermiten
Copy link
Collaborator

I like the second method and for sure it's better than now

@isshininu
Copy link
Contributor

I just want option to have no picture in the background at all T_T

@gandalfthewhite19890404

I just want option to have no picture in the background at all T_T

Set transparency to 0.
What do you think about transparency slider as solution?

@isshininu
Copy link
Contributor

Set transparency to 0. What do you think about transparency slider as solution?

if it solves my problem and makes background solid, then it's good

@MuntKaicho
Copy link
Author

I just want option to have no picture in the background at all T_T

you can make a dummy pic1.png that's fully transparent and go into your user/game_data/ folder and copy it in all the folders there if you want to do that

@gsanjin
Copy link

gsanjin commented Jan 31, 2025

Any chance to have option to disable this background? I did notice answer about transparency but that is not obvious setting.

@pablodrake
Copy link
Contributor

pablodrake commented Feb 2, 2025

Hi currently implementing a fix for this based on option 2, will post UI and example images in pr but I want to ask if it is acceptable to break filename backwards compatibility with metadata file for background image in order to store the current opacity to check if we need to recalculate image on user change.

I'm currently debating on either storing the opacity in the filename like "pic1_50.png" (50 for opacity level) this would leave unused "pic1.png" metadata file on users machine, could be corrected by explicit check in code to modify the filename to the new format.
The second option would be to create another metadata file that could be called "opacity.txt" and store the value inside.

I would gladly accept suggestions on what solution to implement.

(Edit)
First option and deleting any png that starts with "pic1" if we need to recalculate the image is the sanest choice I think.

@MuntKaicho
Copy link
Author

You want to implement the transparency on a per-game basis?
I think the best way to handle would be to just use the default pic1.png provided by the game and store a global value for the transparency in the emu settings, with a slider in the settings menu next to the one for the title music. That way users can fully disable it if they want

@pablodrake
Copy link
Contributor

This is the plan, the thing is that the image that is displayed is saved as metadata to avoid recalculating it every time you open the emulator, I will create the pull request soon with examples.

@pablodrake pablodrake linked a pull request Feb 2, 2025 that will close this issue
@pablodrake
Copy link
Contributor

Check out the pr above this message, I posted example of my implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants