-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Alternate list preview background #2258
Comments
Did some more testing and 15% is better for the 2nd method because 10% kinda kills off all detail in very dark images like Bloodborne |
I like the second method and for sure it's better than now |
I just want option to have no picture in the background at all T_T |
Set transparency to 0. |
if it solves my problem and makes background solid, then it's good |
you can make a dummy pic1.png that's fully transparent and go into your user/game_data/ folder and copy it in all the folders there if you want to do that |
Any chance to have option to disable this background? I did notice answer about transparency but that is not obvious setting. |
Hi currently implementing a fix for this based on option 2, will post UI and example images in pr but I want to ask if it is acceptable to break filename backwards compatibility with metadata file for background image in order to store the current opacity to check if we need to recalculate image on user change. I'm currently debating on either storing the opacity in the filename like "pic1_50.png" (50 for opacity level) this would leave unused "pic1.png" metadata file on users machine, could be corrected by explicit check in code to modify the filename to the new format. I would gladly accept suggestions on what solution to implement. (Edit) |
You want to implement the transparency on a per-game basis? |
This is the plan, the thing is that the image that is displayed is saved as metadata to avoid recalculating it every time you open the emulator, I will create the pull request soon with examples. |
Check out the pr above this message, I posted example of my implementation. |
Checklist
Description
So the current implementation where the emu scrapes pic1.png from the game files and then applies the blur looks kinda weird in some situations, especially with brighter images.
I think that just taking the image and applying a simple 90% opacity full black overlay atop the image or just taking the image and generating a version of it that only has 10% opacity can yield better results.
Current:
Proposed black overlay:
Proposed 10% opacity:
Reason
The current implementation looks strange, as if there isn't just gaussian blur applied, but also has a low resolution look to it.
Examples
No response
The text was updated successfully, but these errors were encountered: