Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing error codes to SheetMetalUnfolder.py #98

Closed
luzpaz opened this issue Oct 14, 2019 · 6 comments
Closed

Add missing error codes to SheetMetalUnfolder.py #98

luzpaz opened this issue Oct 14, 2019 · 6 comments

Comments

@luzpaz
Copy link
Collaborator

luzpaz commented Oct 14, 2019

There are certain places in the SheetMetalUnfolder.py that are missing error codes.

# TODO: Error Codes
# - Put error numbers into the text
# - Put user help into more texts

else:
print('FIXME! make errorcondition')

if vert0Idx is None:
#print 'catastrophy: ', fEdge.Vertexes[0].Point, ' ', fEdge.Vertexes[1].Point, ' ', eType
Part.show(fEdge, 'catastrophyEdge')
# FIXME, need proper failure mode.

if oppoPoint is None:
print(' error need always an opposite point in a side face!')
# FIXME: need a proper error condition.

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 8, 2021

Looks like @matthewdickinson's PR #10 was trying to address this

@luzpaz
Copy link
Collaborator Author

luzpaz commented Jul 3, 2021

@shaise was this actually realized?

@shaise
Copy link
Owner

shaise commented Jul 4, 2021

No, the PR was conflicting

@luzpaz luzpaz changed the title Add missing error codes to SheetMetalUnfolder.py Add missing error codes to SheetMetalUnfolder.py Nov 7, 2022
@luzpaz
Copy link
Collaborator Author

luzpaz commented Nov 9, 2022

Updated ticket with hyperlinked references in to the code

@alexneufeld
Copy link
Contributor

@shaise This is probably not needed anymore, as we'll be using the new unfolder for the most part going forward

@luzpaz luzpaz closed this as completed Jan 31, 2025
@shaise
Copy link
Owner

shaise commented Feb 2, 2025

@luzpaz , Yes, with the new unfolder it is obsolete. Thanks for helping me tidy things up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants