Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding guidelines are not followed #2

Open
shakthi-prashanth-m opened this issue Mar 29, 2018 · 0 comments
Open

Coding guidelines are not followed #2

shakthi-prashanth-m opened this issue Mar 29, 2018 · 0 comments

Comments

@shakthi-prashanth-m
Copy link
Owner

shakthi-prashanth-m commented Mar 29, 2018

  • Inconsistency in naming Classes, methods, members, etc.
  • Use of raw pointers throughout the source code. Need to replace raw pointers by smart pointers and references.
  • C++ style is dragged but C-style coding is dominant.
  • C++11 is not strictly adapted.
  • PImpl style is NOT adapted.
  • Selectors are not suffixed with const. Opened pull request to address this: Suffix const for selector methods and parameters Dronecode/camera-manager#152
  • Members are not differentiated uniformly using either mMember or _member or member_, etc.
  • Unnecessary use of operator new.
  • Usage of reference and const reference wherever applicable instead of returning objects by value.
  • New Types must be part of a class if their usage is part of the class. They must not be defined in File scope.
  • Filenames are inconsistent. We need to follow either CamelCase or snake_case. The repository has mixture of both: https://github.com/intel/camera-streaming-daemon/tree/master/src
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant