From aa90e89b7977140a55227a00e2db9cad7f355f75 Mon Sep 17 00:00:00 2001 From: 0t4u <61939142+0t4u@users.noreply.github.com> Date: Sat, 20 Jul 2024 10:14:24 +0800 Subject: [PATCH 1/4] chore: update gh actions versions to latest --- .github/workflows/code-check.yml | 4 ++-- .github/workflows/code-compile.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/code-check.yml b/.github/workflows/code-check.yml index b947458f..f76ced7c 100644 --- a/.github/workflows/code-check.yml +++ b/.github/workflows/code-check.yml @@ -13,12 +13,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: persist-credentials: false - name: Install Node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: 18 - name: Install Deps diff --git a/.github/workflows/code-compile.yml b/.github/workflows/code-compile.yml index 510b527a..17bf73cc 100644 --- a/.github/workflows/code-compile.yml +++ b/.github/workflows/code-compile.yml @@ -18,9 +18,9 @@ jobs: node-version: [18.x] steps: - - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3 + - uses: actions/checkout@v4 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 # tag=v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - run: npm i From 18109701a0c4d6b79e7fb42f75e09690c3c483a9 Mon Sep 17 00:00:00 2001 From: 0t4u <61939142+0t4u@users.noreply.github.com> Date: Sat, 20 Jul 2024 10:14:45 +0800 Subject: [PATCH 2/4] chore: make gh action run for latest lts as well --- .github/workflows/code-compile.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-compile.yml b/.github/workflows/code-compile.yml index 17bf73cc..ed7c2d64 100644 --- a/.github/workflows/code-compile.yml +++ b/.github/workflows/code-compile.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: - node-version: [18.x] + node-version: [18.x, 20.x] steps: - uses: actions/checkout@v4 From c187f40605a41e4f752b5cbb78df5009e0a3e303 Mon Sep 17 00:00:00 2001 From: 0t4u <61939142+0t4u@users.noreply.github.com> Date: Fri, 19 Jul 2024 14:10:25 +0800 Subject: [PATCH 3/4] fix: pin @augu/eslint-config to 4.0.1 to support eslintrc --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5289f1e7..d21dcda8 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "ws": "^8.17.1" }, "devDependencies": { - "@augu/eslint-config": "^5.2.4", + "@augu/eslint-config": "4.0.1", "@swc/core": "^1.6.13", "@types/node": "^20.14.9", "@types/node-fetch": "^2.6.11", From 428f92c432a1875d1770e54c312147a1f47a448d Mon Sep 17 00:00:00 2001 From: 0t4u <61939142+0t4u@users.noreply.github.com> Date: Sat, 20 Jul 2024 00:50:29 +0800 Subject: [PATCH 4/4] fix: silence eslint warning --- src/Shoukaku.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Shoukaku.ts b/src/Shoukaku.ts index 7e0dd16f..5b363ca5 100644 --- a/src/Shoukaku.ts +++ b/src/Shoukaku.ts @@ -291,7 +291,7 @@ export class Shoukaku extends EventEmitter { if (player) { try { await player.destroy(); - } catch (_) {} + } catch (_) { /* empty */ } player.clean(); this.players.delete(guildId); }