From e731c602e1366b953b3770a0539bc983fcf0672c Mon Sep 17 00:00:00 2001 From: Sven Nierlein Date: Mon, 7 Oct 2024 15:15:24 +0200 Subject: [PATCH 1/3] add unit test for sensors.TemperaturesWithContext --- sensors/sensors_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sensors/sensors_test.go b/sensors/sensors_test.go index 454316a9c..ff13867b2 100644 --- a/sensors/sensors_test.go +++ b/sensors/sensors_test.go @@ -3,8 +3,11 @@ package sensors import ( + "context" "fmt" "testing" + + "github.com/shirou/gopsutil/v4/sensors" ) func TestTemperatureStat_String(t *testing.T) { @@ -19,3 +22,8 @@ func TestTemperatureStat_String(t *testing.T) { t.Errorf("TemperatureStat string is invalid, %v", fmt.Sprintf("%v", v)) } } + +func TestTemperatures(t *testing.T) { + // make sure it does not segfault + sensors.TemperaturesWithContext(context.TODO()) +} From 25d60f8360f5159b8aedf6e9fd1a648fe224b79d Mon Sep 17 00:00:00 2001 From: Sven Nierlein Date: Mon, 14 Oct 2024 08:46:24 +0200 Subject: [PATCH 2/3] Update sensors/sensors_test.go Co-authored-by: shirou --- sensors/sensors_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/sensors/sensors_test.go b/sensors/sensors_test.go index ff13867b2..cfb88e894 100644 --- a/sensors/sensors_test.go +++ b/sensors/sensors_test.go @@ -6,8 +6,6 @@ import ( "context" "fmt" "testing" - - "github.com/shirou/gopsutil/v4/sensors" ) func TestTemperatureStat_String(t *testing.T) { From b339e38e1d9a00a72eb58ed5d2afb03f84f3fade Mon Sep 17 00:00:00 2001 From: Sven Nierlein Date: Mon, 14 Oct 2024 08:46:35 +0200 Subject: [PATCH 3/3] Update sensors/sensors_test.go Co-authored-by: shirou --- sensors/sensors_test.go | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/sensors/sensors_test.go b/sensors/sensors_test.go index cfb88e894..eb7110e96 100644 --- a/sensors/sensors_test.go +++ b/sensors/sensors_test.go @@ -21,7 +21,24 @@ func TestTemperatureStat_String(t *testing.T) { } } +func skipIfNotImplementedErr(t *testing.T, err error) { + if errors.Is(err, common.ErrNotImplementedError) { + t.Skip("not implemented") + } +} + func TestTemperatures(t *testing.T) { - // make sure it does not segfault - sensors.TemperaturesWithContext(context.TODO()) + if os.Getenv("CI") != "" { + t.Skip("Skip CI") + } + + v, err := SensorsTemperatures() + skipIfNotImplementedErr(t, err) + if err != nil { + t.Errorf("error %v", err) + } + if len(v) == 0 { + t.Errorf("Could not get temperature %v", v) + } + t.Log(v) }