Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on pypi? #129

Open
jonathan-s opened this issue Jan 19, 2025 · 8 comments
Open

Release on pypi? #129

jonathan-s opened this issue Jan 19, 2025 · 8 comments

Comments

@jonathan-s
Copy link

jonathan-s commented Jan 19, 2025

Also out of curiosity; might it be worth to team up with > https://github.com/ikegami-yukino/mecab ?

@shogo82148
Copy link
Owner

@ikegami-yukino how do you think?

@ikegami-yukino
Copy link

ikegami-yukino commented Jan 22, 2025

@shogo82148
I agree with this suggestion.
To tell the truth, I am guilty of being behind in updating my MeCab fork.
Also, there is mecab-python3 on PYPI, but it seems to assume the use of the original MeCab, which is no longer maintained.
On the other hand, I think that libraries that assume the use of the maintained MeCab should also be available in PYPI.
So if you tell me your PYPI account, I would like to add you to the collaborators for mecab on PYPI and TestPYPI.
If you don't know how to do a release on PYPI, feel free to ask.

By the way, a session at PyCon JP 2022 reported that it is important that users can write the process they want to implement just by looking at the README.
For this reason, it is advisable to improve the README for PYPI releases.
In particular, it is better to describe the methods introduced in this article.
However, since Neologd is no longer updated, it is not necessary to write an explanation of Neologd.
In addition, example sentences in the code examples may be substituted for any understandable example.

Also, the license files (BSD, GPL, and LGPL) should be included with the distribution at PYPI and these licenses should be described in setup.py.
This is because there are cases where users cannot use the library if the license is not clear.

If you have any questions or would like to talk about something, please feel free to contact me.

@shogo82148
Copy link
Owner

@ikegami-yukino Thank you for your response!
My PyPI account is https://pypi.org/user/shogo82148/
I have never released anything on PyPI, so I may ask you various questions.

@jonathan-s
Copy link
Author

@shogo82148 @ikegami-yukino I would suggest that you decide to work on a single repo. (I don't know which repo is the most updated). So there would only be a single pypi package as a result.

Perhaps the two of you can get inspired by this workflow -> https://github.com/jonathan-s/djantic2/blob/main/.github/workflows/publish.yml

That workflow itself will publish a package to pypi.

@ikegami-yukino
Copy link

@shogo82148
I invited your account to the mecab project in PYPI and Test PYPI😊

@shogo82148
Copy link
Owner

thanks, I have accepted the invitations.

@ikegami-yukino
Copy link

@jonathan-s
I also agree with working on a single repo.

@shogo82148
I will declare that the PYPI mecab repo maintainer will be replaced by shogo-san, what do you think?
I think that I will archive my GitHub mecab repository.

@ikegami-yukino
Copy link

@shogo82148
I've just realized that it's a better idea to add Python 3.13 to build-windows.bat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants