Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate SSleath's button into FF identity button #35

Open
KOLANICH opened this issue Sep 25, 2015 · 1 comment
Open

Integrate SSleath's button into FF identity button #35

KOLANICH opened this issue Sep 25, 2015 · 1 comment

Comments

@KOLANICH
Copy link

Because having 2 buttons for the same purpose is a bit weird
@KOLANICH KOLANICH changed the title Integrate SSleath's butto into FF identity button Integrate SSleath's button into FF identity button Sep 25, 2015
@sibiantony
Copy link
Owner

Had thought about this before. The reason I went for a separate button was that I wanted the rating to be displayed somewhere prominently, without having to go through mouse-clicks.
Also the identity button and the popup is constantly evolving (if you see the current nightly you'll get an idea). Although not unstable, integrating now may not be a good idea.

But PRs are welcome. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KOLANICH @sibiantony