Enabling colorization of address bar breaks selection's background color

[wilkowy]

If colorization of address bar is enabled than selection's background color is reversed than normal (and due to this almost invisible).

Colorization disabled: http://i60.tinypic.com/2prfekp.jpg
Colorization enabled: http://i61.tinypic.com/2640y7c.jpg

SSleuth: 0.3.1
Fx: 30.0

[sibiantony]

Which OS are you using ? I just checked in Linux (Fedora 20) and Windows 7. The selection text and background is normal.
Any ways, I will see if I can override the selection text color in css.

[wilkowy]

It's XP SP3. Now with Fx 31.0.
However it appears to be related with visual themes because with default theme the selection color is as it should be. When I change to any other theme than the selection color is like on previously attached screenshots. I've also tested on a fresh Fx profile with the same results.
When colorization is enabled this happens only on colorized address bars (non-encrypted connections have proper selection color).

[sibiantony]

Okay. Thanks for the details. Unfortunately supporting other themes etc. is way too much for an add-on that focuses on security :(
Even to make sure that things don't break in the default, and that too in 3 platforms (win, linux, mac) is way too much work. Hope you understand.

On the other hand, if you know style sheets and can submit a patch/pull request, I will be happy to apply it. The SSleuth css file can be found here : https://github.com/sibiantony/ssleuth/blob/master/content/skin/ssleuth.css
The ones responsible for urlbar colorizing are defined under #urlbar

[wilkowy]

Of course I'm talking about Fx visual themes (personas), not OS themes. I've tried with ::-moz-selection (modified local ssleuth.css from xpi), but without luck. It looks like related to transparency (image is below address bar) and "accentcolor" parameter of themes.

[sibiantony]

Yes. I meant the same. Be it personas or Fx appearance themes or even OS themes, it is a lot of work to keep each of them happy.
Besides, Fx themes would change the default styling a lot, and they might even have ways to invert colors of selection based on the text color. Perhaps this problem should be addressed in the themes.
I'm glad that URL colorizing is not enabled by default. You can simply disable the colorization if your themes do not play well with the colorization.

[wilkowy]

Actually colorization does not work with any theme (except default). I've installed other address bar customizing addon called Location Bar Enhancer. When user clicks address bar all customizations are removed. Maybe this could be solution (to remove linear gradient when focused)?

[sibiantony]

Nope. The focus on urlbar and applying different style doesn't somehow seem to work.
Secondly, which theme are you using ? I tried with a dark theme in Firefox (FT DeepDark) - which would introduce a dark background with a lighter text color. It also has an inverted selection color which would work fine with the dark theme. Now once I enable colorzing in SSleuth I can see the problem you described. This is because, my linear gradient is from a lighter color towards white.
If instead I make the gradient go towards transparent background, it will be much worse with darker themes, as the text will be unreadable. (color text on dark background)
Also I don't want to play with the selection colors either. That would be incompatible in many cases.

I will have a look in the weekend - but I don't see a universal fits-for-all solution.
Also, I'm not very happy with the colorizing as it is now (which is both a linear gradient towards white + color text ). So If you have some other/better ways of doing colorizing, keep me posted.

[wilkowy]

I use "Three Wolf Moon Shirt". Also it does not work with "Red Juicy Strawberries" and few others which I still had installed. So I tried to look into repo for working themes and I'm surprised to find many, like "Eco theme", "waves y lilavo", "Green Green Grass" and others (dark and light).
Unfortunately it seems that dark/light theme is not the reason as for example "Firefox Organic Grass" (dark, light text) - selection is ok, but "Grazing in the Grass" (dark, light text) - selection is reversed. And now "Deepdark" (50:50 light/dark, dark text) - selection is ok. I couldn't find "FT DeepDark" theme.

This is not a big problem, but as it behaves differently than expected and is quite visually problematic (however selection is not that often used) so I decided to report an issue.

[sibiantony]

Yes. No problem. This issue actually reminds of 'painting the bike-shed' :)

Any ways, I will keep this open. Whenever I'm making any major css changes, will keep this in mind. At the moment this issue is not a priority for me.