Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Automatic kubernetes node labels #563

Open
rothgar opened this issue Aug 16, 2024 · 0 comments
Open

[feature] Automatic kubernetes node labels #563

rothgar opened this issue Aug 16, 2024 · 0 comments

Comments

@rothgar
Copy link
Member

rothgar commented Aug 16, 2024

Problem Description

Nodes in a cluster are not labeled with common labels automatically and users have to run a separate cloud controller to get node labels. This blocks some common application installations that required topology spread or instance type information until the labels are added.

Solution

We should have an option (enabled by default) to have Omni apply well known node labels (via node patch if required) to nodes as part of cluster creation.

Omni already knows information about instance type, zone, and region. But the Kubernetes node labels don't have that information.

It may also be beneficial to continually sync Omni labels with k8s node labels to make troubleshooting and finding instances easier. This could potentially help emulated machines too if the provider was automatically set in omni and in k8s.

Alternative Solutions

Users have to set labels manually via a patch based on Omni node labels.
image

Notes

Setting the label via a patch also creates the annotation for owned-labels which may not be desired

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant