Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous text for Sig Store X (formerly known as Twitter) link #277

Closed
krishnabodawala opened this issue Nov 22, 2023 · 1 comment · Fixed by #278
Closed

Ambiguous text for Sig Store X (formerly known as Twitter) link #277

krishnabodawala opened this issue Nov 22, 2023 · 1 comment · Fixed by #278
Labels
bug Something isn't working

Comments

@krishnabodawala
Copy link

krishnabodawala commented Nov 22, 2023 •
edited
Loading

Description

Link for the Sig Store X (formerly known as Twitter) page does not have meaningful text, creating ambiguity for a screen reader user.

Recommendation: Link text should be I.E. 'Connect us on X' or 'Sig Store on X' to make it more meaningful.

Note

The relevant WCAG success criteria is2.4.4
Reference Accessibility Audit #245

Background

Test performed by Krishna Bodawala Accessibility Consultant Iota
@krishnabodawala krishnabodawala added the bug Something isn't working label Nov 22, 2023
@krishnabodawala krishnabodawala changed the title Ambiguous text for Sig Store X, formally known as Twitter link Ambiguous text for Sig Store X (formerly known as Twitter) link Nov 23, 2023
smythp added a commit to smythp/sigstore-docs that referenced this issue Nov 24, 2023
@smythp
Added aria-label for socials, relabeled dark mode
64a3eb6 
Resolves sigstore#277

Signed-off-by: Patrick Smyth <[email protected]>
@smythp smythp mentioned this issue Nov 24, 2023
Merged
@smythp
Copy link
Collaborator

smythp commented Nov 24, 2023

Created a PR for this. I just went with "Twitter" and "GitHub" for now., rather than "Connect to Sigstore on Twitter" or similar.

ltagliaferri pushed a commit that referenced this issue Nov 26, 2023
@smythp
Fix accessibility issues in header (#278)
9e75cd1 
* Moved logo inside home link

Resolves #275

Signed-off-by: Patrick Smyth <[email protected]>

* Added aria-label for socials, relabeled dark mode

Resolves #277

Signed-off-by: Patrick Smyth <[email protected]>

---------

Signed-off-by: Patrick Smyth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix accessibility issues in header smythp/sigstore-docs
2 participants
@smythp @krishnabodawala