Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for providing identity tokens obtained out-of-band #316

Closed
haydentherapper opened this issue Oct 30, 2024 · 2 comments · Fixed by #319
Closed

Add support for providing identity tokens obtained out-of-band #316

haydentherapper opened this issue Oct 30, 2024 · 2 comments · Fixed by #319
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Collaborator

Description

sigstore-python has support for this already, so we just need to accept an identity token via CLI or via the API and plumb the value through.
@haydentherapper haydentherapper added the enhancement New feature or request label Oct 30, 2024
@di
Copy link
Member

di commented Nov 4, 2024

Specifically, this is the --identity-token flag in sigstore-python: https://github.com/sigstore/sigstore-python/blob/cac62e8e611d4286a49ecda7f33d356381ab7919/README.md#L149-L150

@spencerschrock
Copy link
Contributor

This plumbing should also be useful for our own e2e tests if we use the token published by https://github.com/sigstore-conformance/extremely-dangerous-public-oidc-beacon for our e2e tests discussion in the e2e issue here.

@spencerschrock spencerschrock mentioned this issue Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit identity token argument to SigstoreSigner. spencerschrock/model-transparency
3 participants
@di @spencerschrock @haydentherapper