Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sigstorePublicDefaults versioned API #84

Open
vlsi opened this issue Aug 28, 2022 · 0 comments
Open

Make sigstorePublicDefaults versioned API #84

vlsi opened this issue Aug 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@vlsi
Copy link
Collaborator

vlsi commented Aug 28, 2022

Description

KeylessSigner.builder().sigstorePublicDefaults().build() is nice, however, it makes it hard to peek into the results, as the client have no guarantees on which "defaults" are selected, and the defaults might even change as sigstore-java is updated.

WDYT of making the API like KeylessSigner.builder().sigstorePublicDefaults(SIGSTORE_DEVAULTS_V1).build()?
@vlsi vlsi added the enhancement New feature or request label Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vlsi