Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of redirect uri port #1029

Open
ashearin opened this issue May 21, 2024 · 2 comments
Open

Allow setting of redirect uri port #1029

ashearin opened this issue May 21, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ashearin
Copy link

ashearin commented May 21, 2024

Description

I'm attempting to leverage sigstore-python library for an enterprise signing/verification tool. Working on a proof of concept resulted in this small example:

from sigstore.oidc import Issuer

issuer = Issuer("https://auth.company.com/")

identity = issuer.identity_token(client_id= "signaturevalidationtool", client_secret="super-secret")

Went through the process of setting up an app with our oauth manager to facilitate authentication, however the redirect URI cannot use wildcards with localhost ports. This security configuration choice leaves me stuck, since sigstore-python uses ephemeral ports.

Could we add add the ability to specify this redirect URI? Cosign already has a flag for this

@ashearin ashearin added the enhancement New feature or request label May 21, 2024
@woodruffw
Copy link
Member

Thanks for filing this @ashearin!

Yes, I think exposing this would be fine -- IMO we should expose it only via the API for now and then think about an appropriate CLI option (I've been trying to minimize the number of CLI flags used to configure Sigstore's underlying instances, so we could maybe get this added to the trust configuration or similar instead).

If you send a PR for this, I'd be happy to review and merge it 🙁. Otherwise I'll attempt this in the next few weeks (I'm traveling with limited computer access until early June).

@woodruffw woodruffw added good first issue Good for newcomers help wanted Extra attention is needed labels May 22, 2024
@jku
Copy link
Member

jku commented May 24, 2024

With regards to CLI tool options I agree that a flag should not be added for something like this... However, this fits SigningConfig really well: if it was added there, sigstore-python could support that through the already existing --trust-config flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants