Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client libraries should verify after signing #296

Open
znewman01 opened this issue Sep 5, 2023 · 1 comment
Open

Client libraries should verify after signing #296

znewman01 opened this issue Sep 5, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@znewman01
Copy link

In the Sigstore clients special interest group meeting today, we discussed an issue with the release signatures on CPython.

We have two recommendations for client libraries:

  1. After signing, the clients MUST verify the signature (see Sigstore client spec). 2.
  2. Client library interfaces SHOULD allow callers to specify an identity (and other verification parameters) to use for this verification.

I'm going to be a bit lazy (sorry) and rather than inspecting every client library by hand, just ask whether you're doing the these and, if not, whether you all agree with these recommendations.

@znewman01 znewman01 added the enhancement New feature or request label Sep 5, 2023
@flavio
Copy link
Member

flavio commented Sep 7, 2023

Thanks for having reached out. We do not perform a verification after the signature is created.

The question is, should this be done inside of the low-level library (like sigstore-rs) or should this be done by the author of a 3rd party sigstore client that is built with Rust and sigstore-rs?

To be more concrete. Let's image the use case of extending cargo so that when publishing a crate the developer can also sign the release using sigstore. Should the verification be done inside of the cargo codebase or should it be done by sigstore-rs when some parameters are given to the "create signature" API?

I see pros and cons with both approaches. Is there some consensus among the other libraries implementing the sigstore spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants