Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo check warning with "--no-default-features" #416

Open
jku opened this issue Oct 24, 2024 · 0 comments
Open

cargo check warning with "--no-default-features" #416

jku opened this issue Oct 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jku
Copy link
Member

jku commented Oct 24, 2024

cargo check --no-default-features complains like this:

warning: method `verify_prehash` is never used
   --> src/crypto/verification_key.rs:334:19
    |
124 | impl CosignVerificationKey {
    | -------------------------- method in this implementation
...
334 |     pub(crate) fn verify_prehash(&self, signature: Signature, msg: &[u8]) -> Result<()> {
    |                   ^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

This happens on CI in the check-wasm job so all runs have an annoying annotation about this. I'm not sure what the correct fix is so just am just filing this issue.

@jku jku added the bug Something isn't working label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant