Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug about setting a globalbox #3

Open
chenhanpolyu opened this issue Jan 13, 2022 · 2 comments
Open

Bug about setting a globalbox #3

chenhanpolyu opened this issue Jan 13, 2022 · 2 comments

Comments

@chenhanpolyu
Copy link

First I would like to thank you for your code and it has been used in my project, showing very impressive performance in computing efficiency and convenience. However, when recently I want to try to limit the spatial range of the Polyhedrons, I found the globalbox function offered by your code may has a BUG:https://github.com/sikang/DecompUtil/blame/b0836c7228d19f0fa97282c584b55adf642279da/include/decomp_util/ellipsoid_decomp.h#:~:text=Vs.add(Hyperplane3D(Vec3f(0%2C%20global_bbox_max_(1)%2C%200)%2C%20Vec3f(0%2C%20-1%2C%200)))%3B
I think this line should be Vs.add(Plane3D(Vec3f(0, global_bbox_min_(1), 0), Vec3f(0, -1, 0)));. Right? Or it will generate too many polyhedra than expected.

@ZYS98
Copy link

ZYS98 commented Jan 9, 2023

Did you publish your project in Github @chenhanpolyu ? I'm trying to implement the convex decomposition in Python/Matlab in 2D, but I am running into some problems.

@liangbingning
Copy link

您是否在 Github 上发布了您的项目?我正在尝试在 Python/Matlab 中以 2D 形式实现凸分解,但我遇到了一些问题。

Have you done zhe job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants