Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle rate limiting #115

Open
briskt opened this issue Jan 20, 2025 · 1 comment
Open

handle rate limiting #115

briskt opened this issue Jan 20, 2025 · 1 comment

Comments

@briskt
Copy link
Contributor

briskt commented Jan 20, 2025

Most APIs have rate limiting to prevent excess usage, which causes failure if personnel-sync has many records to update at once. The REST API adapter should implement some type of retry to handle this gracefully.

@briskt
Copy link
Contributor Author

briskt commented Jan 21, 2025

The config options BatchSize and BatchDelaySeconds are a crude implementation that works most of the time. They aren't well documented, and may not work in every situation. For instance, do the "list" requests count against rate limit counters? If so, since the number of "list" requests are needed is unknown at the time the configuration is written, it is not possible to know how large to set the BatchSize parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant