Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book Collection without traditional books breaks conversion process #581

Open
FyreByrd opened this issue May 28, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@FyreByrd
Copy link
Collaborator

FyreByrd commented May 28, 2024

If one of the book collections in an SAB project has no traditional books (e.g. it only has quizzes), then the conversion process will fail during the convert books step.

The failure happens because the Proskomma instance for the book collection does not contain any documents, and thus does not return usable information when queried during the catalog creation process.

PR #580 attempts to address this issue, but potentially causes much bigger problems elsewhere.

Fixing this issue may require a fix in SAB to disallow collections without traditional books, unless that is a valid use case.

@FyreByrd FyreByrd added the bug Something isn't working label May 28, 2024
@FyreByrd FyreByrd linked a pull request May 28, 2024 that will close this issue
@FyreByrd FyreByrd removed a link to a pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant