Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte 5 upgrade (NPM only, no migration) #1174

Open
rmunn opened this issue Oct 28, 2024 · 3 comments · May be fixed by #1283
Open

Svelte 5 upgrade (NPM only, no migration) #1174

rmunn opened this issue Oct 28, 2024 · 3 comments · May be fixed by #1283
Assignees
@rmunn
Labels
🧑‍💻 DX Developer experience problem Svelte owner: Robin

Comments

@rmunn
Copy link
Contributor

rmunn commented Oct 28, 2024 •
edited
Loading

Describe the feature
We want to try migrating to Svelte 5, but the following projects don't support Svelte 5 yet:

  • svelte-intl-precompile (open issue for Svelte 5 support, no PR yet) Supports Svelte 5 just fine since stores are not going away in Svelte 5; the peer dependency error from PNPM is safe to ignore.

That's it! The other libraries we use have released a Svelte 5 version (in some cases requiring a major version bump), and svelte-intl-precompile safely supports Svelte 5 despite the peer dependency warning. So we've decided to try upgrading to use the Svelte 5 NPM packages (including upgrading svelte-check, vite-plugin-svelte, and so on). Then we'll see if anything breaks, and we'll get some practice upgrading components to use runes one at a time before we run pnpx svelte-migrate svelte-5.
@rmunn rmunn added the Svelte owner: Robin label Oct 28, 2024
@hahn-kev
Copy link
Collaborator

Does svelte-intl-precompile not work in Svelte 5? Sure it uses stores, but that should work fine.

@rmunn
Copy link
Contributor Author

rmunn commented Nov 1, 2024

Yes, it should work, but you'll get a warning from pnpm because it depends on precompile-intl-runtime, which in turn declares peer dependencies on "svelte": "^3.37.0 || ^4.0.0". precompile-intl-runtime doesn't yet have an issue open for adding Svelte 5 to its peer dependencies list. So until we've tested it, I plan to leave svelte-intl-precompile on the list — for now, at least. (If it does work, we should file an issue with precompile-intl-runtime to let the developer know that it works with Svelte 5 on at least our codebase).

@rmunn
Copy link
Contributor Author

rmunn commented Nov 26, 2024

We decided to upgrade to the Svelte 5 NPM package and check if svelte-intl-precompile really is a blocker, and it turns out it's not. So this issue isn't quite named correctly anymore.

@rmunn rmunn changed the title Svelte 5 blockers Svelte 5 upgrade (NPM only, no migration) Nov 26, 2024
@rmunn rmunn self-assigned this Nov 26, 2024
@rmunn rmunn linked a pull request Nov 26, 2024 that will close this issue
Draft
@hahn-kev hahn-kev added the 🧑‍💻 DX Developer experience problem label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmunn rmunn

Labels
🧑‍💻 DX Developer experience problem Svelte owner: Robin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Svelte 5 without migration sillsdev/languageforge-lexbox
2 participants
@rmunn @hahn-kev