Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky visual diffing tests #1518

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix flaky visual diffing tests #1518

merged 2 commits into from
Oct 31, 2023

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Oct 31, 2023

I'm replacing text-decoration: underline dotted, which is a relatively new shorthand syntax and seems to be the cause of our flaky visual diffing tests, with an old-school border-bottom to see if it improves things.

@axelboc
Copy link
Contributor Author

axelboc commented Oct 31, 2023

/approve

@axelboc
Copy link
Contributor Author

axelboc commented Oct 31, 2023

All tests passed on first attempt 🥳

@axelboc axelboc requested a review from loichuder October 31, 2023 10:49
@axelboc axelboc merged commit d890800 into main Oct 31, 2023
8 checks passed
@axelboc axelboc deleted the fix-flaky-tests branch October 31, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder