Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Expected dataset to have numeric type #1523

Closed
kdheepak opened this issue Nov 8, 2023 · 2 comments
Closed

Error: Expected dataset to have numeric type #1523

kdheepak opened this issue Nov 8, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@kdheepak
Copy link

kdheepak commented Nov 8, 2023

Describe the bug

When using the signal attribute on a group, I get a Expected data to be numeric error message. This seems to work for other HDF5 files though.

In the screenshots below, the left hand side is the h5web interface for chopper.nxs and the right hand side is the file that we are trying to create with the signal attribute on one of the groups:

image
image

So I don't believe this is a bug necessarily. I think this is us incorrectly setting some attribute?

To Reproduce

  1. Download this file

output-testing.zip

  1. Open this file in h5web.
  2. Click on nexus_entry/nx_data

Expected behaviour

We expect the plot to be seen because the signal attribute points to Dmd2

Screenshots

The plot shows up as expected when using nexus_entry/nx_data/Dmd2

image

but does not work when clicking on the nexus_entry/nx_data group

Context

  • OS: Windows
  • Browser: VSCode
@kdheepak kdheepak added the bug Something isn't working label Nov 8, 2023
@loichuder
Copy link
Member

Hello @kdheepak

First, let me apologize, you are clearly ahead of us on #1441 since you now have a correctly structured NeXus file while we didn't make the relevant changes in H5Web 😅

In this case, it comes from the axes datasets that store string rather than numerical values (the signal and your NeXus structure is fine).

We don't support yet axes containing strings . For that, we need to do the changes mentioned in #1441 (comment) so that

The axes would still show indices, but the tooltip would display the real axis value

Thanks for the report, that will motivate us to keep working on that 😉

@axelboc axelboc added duplicate This issue or pull request already exists and removed bug Something isn't working labels Nov 9, 2023
@axelboc axelboc closed this as completed Nov 9, 2023
@axelboc axelboc reopened this Nov 9, 2023
@axelboc axelboc closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@loichuder
Copy link
Member

Just to be crystal clear: further progress on this will be tracked at #1441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants