-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #1733
Merged
Upgrade dependencies #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Jan 17, 2025
axelboc
force-pushed
the
up-deps
branch
3 times, most recently
from
January 17, 2025 15:49
3d917fe
to
14ca931
Compare
I had missed a couple of |
/approve |
GitHub just upgraded |
loichuder
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toHaveValue(<num>)
replacestoHaveAttribute('aria-valuenow', <str>)
vitest@3
before upgrading to v6Linting
no-misused-spread
enabled out of the box@typescript-eslint/no-unnecessary-condition
, which convinced me to give it another go. I had disabled it because I thought I had noticed false positives (if you remove an existence condition, you want to be sure it's not needed...), so I tried enabling it again and fixed quite a few valid issues. There was still a false positive in@h5web/shared
withRecord<string, ...>
, but after further investigation, this is not the rule's fault: it's because we haven't enabled thenoUncheckedIndexedAccess
flag. Unfortunately, this reports a lot of "errors", many of which are unfounded — e.g noUncheckedIndexedAccess gives unexpected behavior for string.split microsoft/TypeScript#41638, so I preferred to leave it disabled for now and to disableno-unnecessary-condition
locally.