Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing FLAC audio compresion filter #263

Open
lastephey opened this issue Feb 4, 2023 · 4 comments
Open

contributing FLAC audio compresion filter #263

lastephey opened this issue Feb 4, 2023 · 4 comments

Comments

@lastephey
Copy link

Hi hdf5plugin devs,

Thanks for this nice library. We're about to begin a project with a team that would like to use the FLAC audio compression filter via h5py, and we thought this project might be a good place for it.

We can work on preparing this contribution over the next few months, but first we wanted to check if you're open to this filter and see if there are any concerns to be aware of.

Thank you very much,
Laurie

@lastephey
Copy link
Author

Do we first need to register the FLAC filter with HDF5?

@vasole
Copy link
Member

vasole commented Feb 4, 2023

In principle what you need first is to produce an HDF5 filter plugin. That way your filter will be usable everywhere and not just via h5py. Once you have something working, you can request an official filter ID.

@lastephey
Copy link
Author

Thanks, @vasole. I made the request for a filter ID after I filed this issue and they granted one right away, somewhat surprisingly.

https://portal.hdfgroup.org/display/support/Registered+Filter+Plugins
https://portal.hdfgroup.org/display/support/Filters#Filters-32027

We'll work on preparing the HDF5 plugin and preparing a contribution for this project, too. Thanks for the information.

@ajelenak
Copy link

ajelenak commented Jan 9, 2024

The HDF Portal has undergone changes recently so the correct link for the above information is now: https://portal.hdfgroup.org/documentation/hdf5-docs/registered_filter_plugins.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants