Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve calibration for speed & precision #2103

Open
2 tasks
kif opened this issue Mar 17, 2024 · 0 comments
Open
2 tasks

Improve calibration for speed & precision #2103

kif opened this issue Mar 17, 2024 · 0 comments
Assignees
Labels
enhancement proposal Something which have to be tested

Comments

@kif
Copy link
Member

kif commented Mar 17, 2024

The calibration relies on a least square fit of theoretic (from calibrant) vs calculated 2theta position with the one obtained from the geometry and the position of the peaks.

  • For speed: when wavelength varies, both the calibrant and the geometry part need to be updated. Fitting in q-space (rather than 2theta) would simplify the problem with only one function to call and thus remove some of the python overhead
  • For precision: the density of ieee754 floating point values is maximal around 1.0 thus optimal results should be obtained with delta-q around 1 ... this can be used to discriminate between the different units possible.
@kif kif self-assigned this Mar 17, 2024
@kif kif added enhancement proposal Something which have to be tested labels Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement proposal Something which have to be tested
Projects
None yet
Development

No branches or pull requests

1 participant