Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO-less calibration #660

Open
CJ-Wright opened this issue Aug 25, 2017 · 3 comments
Open

IO-less calibration #660

CJ-Wright opened this issue Aug 25, 2017 · 3 comments
Labels
easy First contribution welcome

Comments

@CJ-Wright
Copy link
Contributor

Currently Calibration requires a valid file path for Calibration.pointfile. Can this be done in memory? It would be nice to separate the actual data processing from the file handling.
@vallsv
Copy link
Collaborator

vallsv commented Sep 4, 2017

HI. I agree, but i hope pyFAI-calib2 will be soon ready to replace pyFAI-calib soon.
Or do you use this class with your own script?
Anyway fill free to send a patch if you like.

@CJ-Wright
Copy link
Contributor Author

We use the class inside a larger library.

@kif
Copy link
Member

kif commented Sep 14, 2017

I think this can be done without too much problems ...
The peak-picker itself and the control-point underneath work properly without "pointfile" as demonstrated in this tutorial:
https://github.com/silx-kit/pyFAI/blob/master/doc/source/usage/tutorial/Goniometer/Rotation-Pilatus100k/Multi120_Pilatus100k.ipynb

Please feel free to submit a patch.

@kif kif added the easy First contribution welcome label Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy First contribution welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kif @CJ-Wright @vallsv