Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometric mask for moving detector #765

Open
picca opened this issue Jan 24, 2018 · 6 comments
Open

Geometric mask for moving detector #765

picca opened this issue Jan 24, 2018 · 6 comments

Comments

@picca
Copy link
Collaborator

picca commented Jan 24, 2018

Hello, I just put an idea here before forgetting about it.

Now that moving detectors are sort of integrated in pyFAI.
It would be nice to have a GeometricMask type which can use the displacement of the detector in order to recompute a mask for a given detector position during the integration.

For example a shadows (beamstop).

This way you define the mask of the beamstop at a position of the detector and when you move the detector this mask is recomputed.

Cheers

Fred

@kif
Copy link
Member

kif commented Jan 25, 2018

This looks complicated ...

@vallsv
Copy link
Collaborator

vallsv commented Jan 26, 2018

I think a good idea could be to have 2 concepts of masks.

  • A mask for the detector (which is all the time the same, to mask pixels of the detector)
  • A mask for the experiment (which only have to be set for few angle of your goniometer i guess, in most of the case it will be empty)

pyfai could take care of merging both instead of using one or the other.

In a second step, instead of a raster per angle for the experiment mask, it could be modelized globally by polygons with azim-radius as points. This structure will be a little tricky to manage at the calibration (then it is not for tomorrow) but it could solve your problem?

@kif
Copy link
Member

kif commented Jan 26, 2018 via email

@vallsv
Copy link
Collaborator

vallsv commented Jan 26, 2018

Hmm you are right, sounds much more difficult, as each angle have its own geometry... It's still doable if the center to not move too much ;-)

@kif
Copy link
Member

kif commented Apr 12, 2018

Thomas is working on vectorial polygons for masking ... this might help

@vallsv
Copy link
Collaborator

vallsv commented Apr 16, 2018

It could be an interesting generic tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants