Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry.get/setPyFAI is unconsitent #897

Open
kif opened this issue Aug 23, 2018 · 1 comment
Open

geometry.get/setPyFAI is unconsitent #897

kif opened this issue Aug 23, 2018 · 1 comment

Comments

@kif
Copy link
Member

kif commented Aug 23, 2018

The getPyFAI method from the detector module produces the arguments to duplicate the object by calling the contructor of the detector class. This is more or less OK.

Unfortunately, this is completely unconsitent with what is done in Geometry and in derivative classes (ai, gr, ...).

@kif
Copy link
Member Author

kif commented Aug 30, 2018

I suggest using get/set_config based on the (new) poni-file definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant