Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx 17+ terminates tasks with  ELIFECYCLE  Command failed with exit code 128. #238

Open
simondotm opened this issue May 1, 2024 · 1 comment

Comments

@simondotm
Copy link
Owner

CTRL+C any Nx running task since upgrading to Nx 17 and I'm seeing this error in the console:

 ELIFECYCLE  Command failed with exit code 128.

image

It also happens in Nx 18.

So I think they've refactored how tasks & processes are managed, and somehow exiting the task runner more aggressively.

This appears to be affecting the Firebase serve executor, since it no longer gets the SIGINT and just bails out, which means the Firebase emulator no longer gets opportunity to shutdown.

Anyone else seeing this?

@simondotm simondotm changed the title Nx 17.x+ terminates tasks with  ELIFECYCLE  Command failed with exit code 128. Nx 17+ terminates tasks with  ELIFECYCLE  Command failed with exit code 128. May 1, 2024
@simondotm
Copy link
Owner Author

This was happening in Node 18, and I tried updating to Node 20 based on a random comment elsewhere, but no difference (yet).

I'm short on ideas for how to fix this, because we have to invoke the custom serve executor from nx task runner, even when spinning up our own process in there, it gets killed without firebase CLI command getting the SIGINT it needs to shutdown the emulator cleanly.

Ideas are very welcome, since it's not great for workflow atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant