Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFA drop duplicates #62

Open
dayanne-castro opened this issue Apr 14, 2018 · 2 comments
Open

TFA drop duplicates #62

dayanne-castro opened this issue Apr 14, 2018 · 2 comments

Comments

@dayanne-castro
Copy link
Collaborator

I was reviewing the TFA function, and I see that it drops duplicated columns in prior (TFs with the same targets... then only one of them would be kept...). Shouldn't we group them instead of randomly dropping TFs?

@dayanne-castro
Copy link
Collaborator Author

Nevermind, I think I get it now... It is just to either allow that or not, but why shouldn't we group these TFs?

@kostyat
Copy link
Contributor

kostyat commented May 1, 2018

Grouping them would be logical, we'd just have to write code in order to untangle them in the end so that we could evaluate network performance consistently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants