You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During normal operation on ocs-web I always see the Encoder Summary report something like, "1.9928 Hz, ? ago". The "? ago" makes me not really trust whether the rotation rate is reporting correctly, especially when the HWP is stopped.
I dug into this and found ocs-web is expecting 'encoder_last_updated' at the same level as 'enc_freq' in the response dict.
However, the supervisor agent appears to be exposing only part of the encoder agent's session data in the high level 'hwp_state' part of its session.data. The frequency and timestamp are still available under 'monitored_sessions', but based on the 'enc_freq', 'last_quad', and 'last_quad_time' being reported in 'hwp_state', I think we should also add 'encoder_last_updated' in this part of the response. If it uses this key then ocs-web should report the time without modification, though 'enc_freq_time' would present a consistent convention.
The alternative is to get ocs-web to inspect 'monitored_sessions' instead. In either case the documentation of the session.data object should be improved in the supervisor's docstrings, as this issue seems to stem, at least in part, from unclear documentation of the session.data structure. For instance 'hwp_state' is just 'state' in the docstring and 'enc_freq' is 'hwp_freq'.
During normal operation on ocs-web I always see the Encoder Summary report something like, "1.9928 Hz, ? ago". The "? ago" makes me not really trust whether the rotation rate is reporting correctly, especially when the HWP is stopped.
I dug into this and found ocs-web is expecting
'encoder_last_updated'
at the same level as'enc_freq'
in the response dict.https://github.com/simonsobs/ocs-web/blob/ec5ab52bf168802e3b18bb2893eb191a899ab739/src/panels/HWPSupervisor.vue#L301-L308
However, the supervisor agent appears to be exposing only part of the encoder agent's session data in the high level
'hwp_state'
part of itssession.data
. The frequency and timestamp are still available under'monitored_sessions'
, but based on the'enc_freq'
,'last_quad'
, and'last_quad_time'
being reported in'hwp_state'
, I think we should also add'encoder_last_updated'
in this part of the response. If it uses this key then ocs-web should report the time without modification, though'enc_freq_time'
would present a consistent convention.The alternative is to get ocs-web to inspect
'monitored_sessions'
instead. In either case the documentation of thesession.data
object should be improved in the supervisor's docstrings, as this issue seems to stem, at least in part, from unclear documentation of thesession.data
structure. For instance'hwp_state'
is just'state'
in the docstring and'enc_freq'
is'hwp_freq'
.EDIT: Snapshot of supervisor response:
supervisor-monitor-resp-snapshot.txt
And encoder response:
socs image tag:
v0.5.1-22-g7d2f158-dev
The text was updated successfully, but these errors were encountered: