Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for empty extra-openai-models.yaml file #505

Open
JoeGermuska opened this issue Jun 4, 2024 · 0 comments · May be fixed by #562
Open

Better handling for empty extra-openai-models.yaml file #505

JoeGermuska opened this issue Jun 4, 2024 · 0 comments · May be fixed by #562

Comments

@JoeGermuska
Copy link

I made a extra-openai-models.yaml file thinking I would work on getting Azure OpenAI working with llm Then I learned that that's not quite as straightforward as I thought, so I left the empty file there and moved on to other things.

later, I forgot that was there, and I tried to use llm with regular OpenAI and got this

…
  File "/Users/germuska/.virtualenvs/data/lib/python3.8/site-packages/llm/default_plugins/openai_models.py", line 45, in register_models
    for extra_model in extra_models:
TypeError: 'NoneType' object is not iterable

Deleting the empty extra-openai-models.yaml got me back to using llm but it seems like it would be easy enough to handle this error so logging, and maybe i'll even add a PR if that would be helpful

AlexanderYastrebov added a commit to AlexanderYastrebov/llm that referenced this issue Aug 30, 2024
Fixes simonw#505

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov linked a pull request Aug 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant