-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The xinetd module should not manage files if $package_ensure == absent #66
Comments
* Ensure that the module does not manage files if the package is being removed * Added .rubocop.yml Closes simp#66
Not yet. I got all kinds of errors. Notice that the module seems to want to restart the xinetd service. It's entirely possible that my system is so screwed up that the xinetd module can't recover my system.
The RPM package xinetd will automatically stop the service upon its removal from RHEL type systems. It's probably not best practice to rely on that behavior in the Puppet module but not managing the service upon the package's removal might fix it for me. |
@bschonec It seems unlikely that this change could cause that. The gist of the change is that, if the package is to be removed, that's the only thing that puppet will touch. Everything else is disabled. |
Indeed @trevor-vaughan you are correct. I had a typo in my Puppet file that was preventing R10k from pulling down your branch and Puppet was still using my crappy branch. Your branch does fix the problems that I was experiencing. Thank for submitting the code. |
* Honor package removal * Ensure that the module does not manage files if the package is being removed * Added .rubocop.yml * fix the changelog * raise timeout of FIPS jobs Closes #66
Ported over from PR creation by @bschonec in #65.
The text was updated successfully, but these errors were encountered: