The xinetd module should not manage files if $package_ensure == absent

[trevor-vaughan]

Ported over from PR creation by @bschonec in #65.

When uninstalling the xinetd package, this module attempts to manage /etc/xined.conf, /etc/xinetd.d/ files and attempts (in vain) to start the xinetd service.

I couldn't figure out how to open a new issue so I've commented the init.pp file appropriately and am asking for comments on this issue.

I have about 50 servers that need xinetd with the exception of one. In the node's YAML file, I've put "xinetd::package_ensure: absent" and the module fails because it's trying to manage the xinetd files when it shouldn't.

Yes, I realize I could write a conditional check NOT to include ::xinetd::service but then I'd eventually have spaghetti code trying to work around the module's bug. I'm kind of a purist and believe that the module should do no harm even when it's called and the packages don't need to be installed.

[trevor-vaughan]

@bschonec can you see if the PR in #67 does what you expect?

[bschonec]

Not yet. I got all kinds of errors. Notice that the module seems to want to restart the xinetd service. It's entirely possible that my system is so screwed up that the xinetd module can't recover my system.

Notice: /Stage[main]/Xinetd/Package[xinetd]/ensure: removed (corrective)
Notice: /Stage[main]/Xinetd/File[/etc/xinetd.conf]/ensure: defined content as '{sha256}e5a385d3997cc6501049df0016fb693af8f975da686450d731e7e3b57d79d20c' (corrective)
**Info: /Stage[main]/Xinetd/File[/etc/xinetd.conf]: Scheduling refresh of Service[xinetd]
Error: Systemd start for xinetd failed!**
journalctl log for xinetd:
-- Logs begin at Fri 2022-05-20 07:55:06 EDT, end at Fri 2022-05-20 15:54:53 EDT. --


<snip a bunch of stuff>

Error: /Stage[main]/Xinetd/Service[xinetd]/ensure: change from 'stopped' to 'running' failed: Systemd start for xinetd failed!
journalctl log for xinetd:
-- Logs begin at Fri 2022-05-20 07:55:06 EDT, end at Fri 2022-05-20 15:54:53 EDT. --

<snip a bunch of stuff>

Notice: /Stage[main]/Xinetd/Service[xinetd]: Triggered 'refresh' from 1 event
Info: Class[Xinetd]: Unscheduling all events on Class[Xinetd]

The RPM package xinetd will automatically stop the service upon its removal from RHEL type systems. It's probably not best practice to rely on that behavior in the Puppet module but not managing the service upon the package's removal might fix it for me.

[trevor-vaughan]

@bschonec It seems unlikely that this change could cause that. The gist of the change is that, if the package is to be removed, that's the only thing that puppet will touch. Everything else is disabled.

[bschonec]

Indeed @trevor-vaughan you are correct. I had a typo in my Puppet file that was preventing R10k from pulling down your branch and Puppet was still using my crappy branch.

Your branch does fix the problems that I was experiencing.

Thank for submitting the code.