Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

resource and field naming inconsistency pull_zone/pullzone, storagezone/storage_zone #102

Open
fho opened this issue Nov 16, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@fho
Copy link
Contributor

fho commented Nov 16, 2022

Sometimes resources or fields are named pullzone in other occurrences pull_zone, align the naming.

@fho fho added bug Something isn't working good first issue Good for newcomers labels Nov 16, 2022
@jspizziri
Copy link
Contributor

jspizziri commented Nov 16, 2022

@fho do you also want to correct storagezone => storage_zone too? There's also edgerule vs edge_rule.

@fho
Copy link
Contributor Author

fho commented Nov 16, 2022

true, thanks, the same issue exist with storage_zone.
I can only find edgerule, not the variant with _ in docs/ though.

I tend to prefer using the name without "_" everywhere. What do you think?

@fho fho changed the title resource and field naming inconsistency pull_zone vs pullzone resource and field naming inconsistency pull_zone/pullzone, storagezone/storage_zone Nov 16, 2022
@jspizziri
Copy link
Contributor

@fho I'm fine with either. I was mostly noticing a difference between when the Bunny docs consider it two words vs when we do. If you were to map the bunny names to snake_case then you'd put an underscore in edge_rule too since they call it an Edge Rule rather than an Edgerule. But I'm not very opinionated about it.

@jspizziri
Copy link
Contributor

also, it seems like this would likely be a breaking change, no?

@fho
Copy link
Contributor Author

fho commented Nov 16, 2022

Yes, that would be a breaking change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Development

No branches or pull requests

2 participants