Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first-day-of-week doesn't work as expected #5

Open
DavidGriffith opened this issue Mar 30, 2024 · 1 comment
Open

first-day-of-week doesn't work as expected #5

DavidGriffith opened this issue Mar 30, 2024 · 1 comment

Comments

@DavidGriffith
Copy link

DavidGriffith commented Mar 30, 2024

I thought that the first-day-of-week parameter would make the leftmost column that day of the week. For instance, if first-dat-of-week is 6 for Sunday, the order remains the same with Monday on the left concluding with Sunday or the right. Only the color of the day of the week and the date is changed.

Correction: It looks like if I use 6 to indicate that the day of the week starts on a Sunday, the days are positioned correctly, but the day of the week abbreviations remain as Monday through Sunday.

@DavidGriffith
Copy link
Author

After further analysis, it seems clear that the current behavior is unintended because if the third parameter is used and is something other than zero, the result is an incorrect calendar. I've prepared a pull request to fix this in #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant