Refactor: Replace connected nodes with edges #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add get_opposite_node to calculate given a one of the top nodes the other one. Add get_next_geo_node to calculate the neighbor geo node given one of the top nodes
Replace setting operations of connected_on_... with new connected_edge_on_... property.
Co-authored-by: Lietze <[email protected]>
fixes Bug: Wrong calculation of "Anschluss" if connected edges are long and not straight simulate-digital-rail#41
antonykamp
force-pushed
the
refactor/replace-connected-nodes-with-edges
branch
from
7a6def0
to
51f8a77
Compare
|
@antonykamp Whats the status of this PR? |
|
I forward this to @Lietze and @SaturnHafen 😇 |
|
As far as I am concerned this (and all the other PRs across the org) are ready for review. I will mark them as ready :) Edit: I don't have permissions to mark this pr as ready |
|
Also: The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
connected_nodesand its dependencies withconnected_edgesin theNodeclass and introducesconnected_nodesas property again.Additionally, it adds two functions to the
Edgeclass to get the opposite node given one top node and the neighbor geo node given a top node.fixes #40