Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code reorganization #123

Open
andre-senna opened this issue Dec 10, 2024 · 2 comments
Open

Code reorganization #123

andre-senna opened this issue Dec 10, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@andre-senna andre-senna added this to the Query Engine milestone Dec 10, 2024
@andre-senna andre-senna changed the title Code re-organization Code reorganization Dec 10, 2024
@angeloprobst
Copy link
Collaborator

angeloprobst commented Dec 12, 2024

My suggestion is to unify all related repos (das-attention-broker, das-query-engine, das-atomdb and das-node) into das repository, and then deprecate or delete the original repositories once everything is working and building and being deployed from the das repo.

By doing that, das repo would have a new src directory, to where the code from the other repos would be moved in.

An example of how this new src subdir tree would look like (considering that nanobind projects require CMake-style building but the rest will be managed by Bazel):

src/
├── cpp/
│   ├── atom_db/
│   │   └── BUILD
│   ├── attention_broker/    <-- formerly `attention_broker_server`
│   │   └── BUILD
│   ├── common/
│   │   └── BUILD
│   ├── das_node/
│   │   └── BUILD
│   ├── query_engine/
│   │   └── BUILD
│   └── BUILD
├── nanobind/
│   ├── common/
│   ├── hyperon_das_atomdb_cpp/
│   │   ├── CMakeLists.txt
│   │   └── pyproject.toml
│   └── hyperon_das_node/
│       ├── CMakeLists.txt
│       └── pyproject.toml
├── python/
│   ├── common/
│   │   └── BUILD
│   ├── hyperon_das/
│   │   └── BUILD
│   ├── hyperon_das_atomdb/
│   │   └── BUILD
│   └── BUILD
├── BUILD
└── WORKSPACE

@andre-senna
Copy link
Contributor Author

Makes total sense.

BTW you can drop the "server" from the name of the Attention Broker module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants