Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session expiry is not handled and causes errors #142

Open
siphomateke opened this issue Jun 20, 2019 · 0 comments
Open

Session expiry is not handled and causes errors #142

siphomateke opened this issue Jun 20, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@siphomateke
Copy link
Owner

Version
WIP ledger branch

Describe the bug
If HTTP requests take too long to timeout, the ZRA website expires the login session causing all sorts of errors.

When the session expires, the ZRA website returns an HTML page containing "Your Session has expired. Please login again." Since this isn't a failed request, the tool doesn't treat it as such and various errors occur, particularly when an XML response was expected.

To Reproduce
Steps to reproduce the behavior:

  1. Set a very long HTTP request timeout
  2. Run the action that gets ledger records
  3. Observe that the following error occurs:
TypeError: response['request-params'] is undefined

Expected behavior
When the session expires, the tool should detect this, re-login and continue.

@siphomateke siphomateke added the bug Something isn't working label Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant