Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the implementation of the residual correct? #1

Open
noliramlis opened this issue Mar 3, 2020 · 0 comments
Open

Is the implementation of the residual correct? #1

noliramlis opened this issue Mar 3, 2020 · 0 comments

Comments

@noliramlis
Copy link

I may be wrong but I wonder if the conditioning of the residual is correctly implemented in the BottleNeck class :

    if self.s == 1 and self.exp == self.out:
        return input + output
    else:
        return output

the second condition should compare the channel number of the input and the one of the output (self.out), shouldnt it?

@noliramlis noliramlis changed the title Is the imlementation of the residual correct? Is the implementation of the residual correct? Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant