Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abilities to use lr-mobile-config.js and lr-desktop-config.js #47

Open
Yivan opened this issue Feb 19, 2020 · 2 comments
Open

Abilities to use lr-mobile-config.js and lr-desktop-config.js #47

Yivan opened this issue Feb 19, 2020 · 2 comments
Labels

Comments

@Yivan
Copy link

Yivan commented Feb 19, 2020

Hello,

First I would like to say this extension is really great, it is very convenient for us to be able to run lighthouse tests together with sitespeed.io test, and having the possibility to consult them in just one panel (html reports or grafana).

Actually only two profiles can be extended: default-config.js and full-config.js.

This issue is to sugger to add two more: lr-mobile-config.js and lr-desktop-config.js
So we can set like:

--lighthouse.extends lr-mobile

--lighthouse.extends lr-desktop

This way in combination with the --lighthouse.settings.emulatedFormFactor difference between desktop/mobile are best reflected.

I hope it makes sense.

Thanks!
Best regards

@Yivan
Copy link
Author

Yivan commented Feb 19, 2020

After some further test (please see: #48), adding the possibility to use those 2 new profiles will be a really great things to achieve better result in same line of the results of Google Page Speed Insight.

In the meantime, is there a way to use custom profile or add those two file prrofile manually ? (as they are here: https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/config)

Thanks.

@soulgalore
Copy link
Member

I can review and test a PR for that, it needs to be implemented on our side if I understand correctly see
https://github.com/GoogleChrome/lighthouse/blob/master/docs/configuration.md#config-extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants