ECR Module: Upgrade terraform-aws-provider

[sj-williams]

Background

The ECR Module terraform-aws-provider defined in versions.tf is currently at >=4.0.0. We need to upgrade the provider to the latest major 5 release.

What to do:

• review changelogs for any changes of the terraform resources used within the module
• check for new deprecations
• check for any removals (or existing deprecations) that will impact/break the module usage
• bump the provider version constraints in both environments repo tf resources folder and the module repo's versions file
• test applying a new instance of the AWS resource in abundant / testing namespace
• test that upgrading previous versions of the module works successfully
• cut new module release and prepare for rollout

Proposed user journey

Approach

Which part of the user docs does this impact

Communicate changes

• post for #cloud-platform-update
• Weeknotes item
• Show the Thing/P&A All Hands/User CoP
• Announcements channel

Questions / Assumptions

Definition of done

• readme has been updated
• user docs have been updated
• another team member has reviewed
• smoke tests are green
• prepare demo for the team

Reference

How to write good user stories