fix(jasmine): .and.stub() usage is correctly replaced

skovhus · Sep 15, 2024 · 4a829df · 4a829df
1 parent 17ca751
commit 4a829df
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/transformers/jasmine-globals.test.ts b/src/transformers/jasmine-globals.test.ts
@@ -81,6 +81,8 @@ test('spyOn', () => {
     jest.spyOn(stuff).and.rejectWith('oh no');
     const fetchSpy = spyOn(window, 'fetch').and.resolveTo({json: {}});
     existingSpy.and.callThrough();
+    spyOn(something, 'foo').and.stub().and.returnValue(42);
+    mySpy.and.stub();
     `,
     `
     jest.spyOn().mockReturnValue();
@@ -97,6 +99,8 @@ test('spyOn', () => {
     jest.spyOn(stuff).mockRejectedValue('oh no');
     const fetchSpy = jest.spyOn(window, 'fetch').mockResolvedValue({json: {}});
     existingSpy.mockRestore();
+    jest.spyOn(something, 'foo').mockReturnValue(42);
+    mySpy.mockImplementation(() => {});
     `
   )
 })

diff --git a/src/transformers/jasmine-globals.ts b/src/transformers/jasmine-globals.ts
@@ -176,13 +176,10 @@ export default function jasmineGlobals(fileInfo, api, options) {
           break
         }
         // This is transformed by the *.and.*() expression handling below
+        case 'rejectWith':
         case 'resolveTo': {
           break
         }
-        // This is transformed by the *.and.*() expression handling below
-        case 'rejectWith': {
-          break
-        }
         default: {
           logWarning(
             `Unsupported Jasmine functionality "jasmine.createSpy().and.${spyType}".`,
@@ -362,6 +359,17 @@ export default function jasmineGlobals(fileInfo, api, options) {
           ]
           break
         }
+
+        case 'stub': {
+          if (path.parentPath.node.type === 'MemberExpression') {
+            j(path).replaceWith(path.node.callee.object.object)
+          } else {
+            path.node.callee.object = path.node.callee.object.object
+            path.node.callee.property.name = 'mockImplementation'
+            path.node.arguments = [emptyArrowFn]
+          }
+          break
+        }
       }
     })