Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Controller (Step 5) #332

Open
7 tasks
grahamia opened this issue Jul 4, 2024 · 0 comments · May be fixed by #408
Open
7 tasks

Provider Controller (Step 5) #332

grahamia opened this issue Jul 4, 2024 · 0 comments · May be fixed by #408
Assignees
Labels
enhancement New feature or request

Comments

@grahamia
Copy link
Contributor

grahamia commented Jul 4, 2024

Overview

Now that we have simplified our run completion events setup (#359) we can implement a controller to manage Provider custom resources (introduced in #329). The beauty of being down to one component in the provider layer (replacing our Argo Events setup with a single Deployment) is that we have no need to manage multiple resources, so we have no need for helm, and therefore the controller can apply the resource directly.

Technical Details

  • Permissions for the Provider controller should be added to the existing roles.yaml, so the temporary manager-providers-viewer-rolebinding ClusterRoleBinding can be removed

Current Architecture

image

After Architecture

image

Acceptance Criteria

  • When applying a new provider custom resource, the provider service Deployment resource is created
  • When updating an existing Provider resource, the provider service Deployment is updated
  • When deleting a Provider resource, the provider service Deployment is deleted
  • If a provider service Deployment is updated by something other than the Provider controller, the Deployment is re-synced to the desired state specified in the Provider resource
  • If a provider service Deployment is deleted by something other than the Provider controller, a new provider service Deployment is created (similarly to how ReplicaSets re-create Pods when deleted)
  • The provider service Deployment must have a unique name (similar to how Deployments create pods with unique names)
  • The KFP Operator docs have been updated as needed
@grahamia grahamia added enhancement New feature or request unrefined labels Jul 4, 2024
@grahamia grahamia added this to the Provider Custom Resource milestone Jul 4, 2024
@grahamia grahamia changed the title Provider Controller Provider Operator Jul 22, 2024
@grahamia grahamia changed the title Provider Operator Provider Controller Jul 24, 2024
@grahamia grahamia changed the title Provider Controller Provider Controller (Step 4) Aug 30, 2024
@grahamia grahamia changed the title Provider Controller (Step 4) Provider Controller (Step 5) Aug 30, 2024
@alexgeorgousis alexgeorgousis linked a pull request Dec 5, 2024 that will close this issue
19 tasks
@alexgeorgousis alexgeorgousis removed their assignment Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants