Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle multi-parent commits #16

Closed
albx79 opened this issue Jan 20, 2020 · 0 comments · Fixed by #21
Closed

Properly handle multi-parent commits #16

albx79 opened this issue Jan 20, 2020 · 0 comments · Fixed by #21

Comments

@albx79
Copy link
Contributor

albx79 commented Jan 20, 2020

In case of merge commits, what-bump always follows the first parent, which happens to be the main branch. This breaks when the release tag is on a separate branch: in this case what-bump will follow all commits on the main branch `til the root is found, then stops.

Ideally, what-bump should do what git does, and properly find a path from HEAD up to the revision specified on the command-line. However, I have no idea how to achieve this.

If multiple paths exist from HEAD to the target revision, then some way to disambiguate would be desirable (even though either erroring out or choosing an arbitrary path by default would be OK).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant