Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] tests/unit_tests/test_controller_utils.py fails when controller resources is set #4172

Open
cblmemo opened this issue Oct 24, 2024 · 0 comments

Comments

@cblmemo
Copy link
Collaborator

cblmemo commented Oct 24, 2024

My skypilot config:

serve:
  controller:
    resources:
      cloud: aws

This result in the following error in the unittest. We should consider monkeypatching the config controller resource to avoid such error.

pytest tests/unit_tests/test_controller_utils.py
D 10-24 16:45:04 skypilot_config.py:228] Using config path: /home/txia/.sky/config.yaml
D 10-24 16:45:04 skypilot_config.py:233] Config loaded:
D 10-24 16:45:04 skypilot_config.py:233] {'serve': {'controller': {'resources': {'cloud': 'aws'}}}}
D 10-24 16:45:04 skypilot_config.py:245] Config syntax check passed.
bringing up nodes...
....F.
==================================================================================================== FAILURES =====================================================================================================
_____________________________________________________________ test_get_controller_resources_with_task_resources[serve-default_controller_resources1] ______________________________________________________________
[gw3] linux -- Python 3.9.17 /home/txia/miniconda3/envs/sky-serve/bin/python
tests/unit_tests/test_controller_utils.py:92: in test_get_controller_resources_with_task_resources
    assert not all_cloud_names
E   AssertionError: assert not {'Azure', 'GCP'}
============================================================================================= short test summary info =============================================================================================
FAILED tests/unit_tests/test_controller_utils.py::test_get_controller_resources_with_task_resources[serve-default_controller_resources1] - AssertionError: assert not {'Azure', 'GCP'}
1 failed, 5 passed, 1 warning in 4.79s

Version & Commit info:

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant