Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not being run #219

Open
roussel-ryan opened this issue Dec 16, 2024 · 1 comment
Open

Tests not being run #219

roussel-ryan opened this issue Dec 16, 2024 · 1 comment
Assignees

Comments

@roussel-ryan
Copy link
Collaborator

roussel-ryan commented Dec 16, 2024

Describe the bug
Unit tests for the emittance measurement class (tests/unit_tests/lcls_tools/common/measurements/test_emittance_measurement.py) are not being run, they should fail in the current state of the code.

To Reproduce
Reproduced every time "Python application" github action is run.

Expected behavior
Github action "Python application" should fail.

Additional context
The directory tests/unit_tests/lcls_tools/common/measurements/ is missing an init.py file. This is addressed in #218

@roussel-ryan
Copy link
Collaborator Author

I was able to fix the test not running and will address the error in the emittance measurement class. Track developments in #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants